Digital Workshop

I am using the script below to read a series of names held in a text file into a listbox.
This all works very well but there is always an extra blank line at the bottom of the listbox - Is there a way to remove this, or not generate it in the first place?

Regards

Clive Cartmel


********************************************************
var Names = ""

NamesList = OpenFile("StaffSubjects.txt")

while (NamesList.EndOfFile() == false) {
currentfile = NamesList.ReadLine()
Names = Names + currentfile + "\n"
wait()
}

Listbox.SetSelection(0,-1)
Listbox.ReplaceSelection(Names)

********************************************************

Clive,

Somewhere... there was a basic example of reading text file LINES. Much like you have... but it starts out with the go to First Line and reads that into a variable..
From then on, all the reads populate the displayed text by putting the line return ( \n ) in front of the expression.

maybe:
Names = "\n" + Names + currentfile

I'm pretty sure I used that construct in this sample pub:
viewtopic.php?t=3632&highlight=listbox+tickbox

NamesList.EndOfFile() ? Names = Names + currentfile : Names = Names + currentfile + "\n"

Mack

Thanks for both of your suggestions.

Mack, yours looks very interesting, but could I push you to a little more clarity as to how I implement it with my script?

What does the ? do?

Thanks in anticipation.

Regards

Clive Cartmel

Hi Clive,

It's a conditional operator - basically a smart if-then-else.

Use it in place of your current concatenation:

Names = Names + currentfile + "\n"

It will check the condition of the end-of-file and select the appropriate response - IE concat with new line or concat without new line.

Regards,

Mack

Mack,

Many thanks for the explanation - it works perfectly.
I assume that this is another of those undocumented features that could save us a great deal of time if we knew about them?
I can now go and tidy up a number of publications that had this annoying little feature in the past.

Thanks once again.

Clive

No, not really. The Conditional Operation is merely a useful way of writing this. It could just as easily have been written with the if-else which has been around since day dot and is well documented.

The undocumented would be to use an array and join which is oddly missing despite its sister the split turning up from strings.

Opus Script is basically JavaScript (<=1.2) and there are many books out there that give useful examples. But credit where credit is due - DW have covered a phenomenal amount of fundamental programming through their examples and help guide.

Mack